EqualityForAccumulators

[oxinabox]

Before:

julia> using DataStructures

julia> counter([2,3,4]) == counter([2,4,3]) 
ERROR: MethodError: no method matching get(::DataStructures.Accumulator{Int64,Int64}, ::Int64, ::Symbol)
Closest candidates are:
  get(::ObjectIdDict, ::ANY, ::ANY) at dict.jl:284
  get(::AbstractArray{T,N}, ::Integer, ::Any) at abstractarray.jl:912
  get{K,V}(::Dict{K,V}, ::Any, ::Any) at dict.jl:692
  ...
 in in(::Pair{Int64,Int64}, ::DataStructures.Accumulator{Int64,Int64}, ::Base.#==) at ./dict.jl:10
 in ==(::DataStructures.Accumulator{Int64,Int64}, ::DataStructures.Accumulator{Int64,Int64}) at ./dict.jl:209

Now:

julia> using DataStructures

julia> counter([2,3,4]) == counter([2,4,3]) 
ERROR: MethodError: no method matching get(::DataStructures.Accumulator{Int64,Int64}, ::Int64, ::Symbol)
Closest candidates are:
  get(::ObjectIdDict, ::ANY, ::ANY) at dict.jl:284
  get(::AbstractArray{T,N}, ::Integer, ::Any) at abstractarray.jl:912
  get{K,V}(::Dict{K,V}, ::Any, ::Any) at dict.jl:692
  ...
 in in(::Pair{Int64,Int64}, ::DataStructures.Accumulator{Int64,Int64}, ::Base.#==) at ./dict.jl:10
 in ==(::DataStructures.Accumulator{Int64,Int64}, ::DataStructures.Accumulator{Int64,Int64}) at ./dict.jl:209

Turns out, that all subclasses of Associative,
should implement get(store, key, default)
or otherwise several things break

[codecov]

Codecov Report

Merging #275 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   95.87%   95.87%   +<.01%     
==========================================
  Files          30       30              
  Lines        2228     2229       +1     
==========================================
+ Hits         2136     2137       +1     
  Misses         92       92

Impacted Files	Coverage Δ
src/accumulator.jl	100% <100%> (ø)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c114f0...8ccd860. Read the comment docs.

[kmsquire]

Thanks!