Upgrade to Julia 0.7; switch to HTTP.jl #20

xiuliren · 2018-08-10T04:05:54Z

Julia 0.7 is pretty nice, let's upgrade!

I also switched to HTTP.jl since it is update to Julia 0.7

Fix deprecations

xiuliren · 2018-08-10T04:06:26Z

this is going to fix
#19

joshbode · 2018-08-10T05:44:22Z

Thanks for working on this!
I'm not using Julia in my current job so this is very helpful to keep this up to date

joshbode · 2018-08-13T04:38:35Z

Looks like the Travis and AppVeyor CI files need to be updated for the latest versions.

joshbode · 2018-08-13T04:41:58Z

src/session.jl

@@ -137,19 +141,39 @@ function JWS(credentials::JSONCredentials, claimset::JWTClaimSet, header::JWTHea
    "$payload.$signature"
 end

-function token(credentials::JSONCredentials, scopes::AbstractVector{<: AbstractString})
+"""


Looking at #21 - HTTP.URIs.escapeuri should cover this

xiuliren · 2018-08-14T01:38:09Z

@joshbode I just updated the travis and appveyor and other code, but still have some test error of storage api. I got some difficulty to locate the error code, do you have any idea?

test gsdict io: Error During Test at /usr/people/jingpeng/.julia/dev/BigArrays/test/backen
ds/GSDicts.jl:7                                                                           
  Got exception MethodError(iterate, (nothing,), 0xffffffffffffffff) outside of a @test   
  MethodError: no method matching iterate(::Nothing)                                      
  Closest candidates are:                                                                 
    iterate(::Any) at essentials.jl:853                                                   
    iterate(::Any, !Matched::Any) at essentials.jl:847                                    
    iterate(!Matched::Core.SimpleVector) at essentials.jl:583                             
    ...

xiuliren · 2018-10-04T18:30:58Z

here is the full error message:

┌ Warning: Error in @async writebody task
│   exception =
│    MethodError: no method matching iterate(::Nothing)
│    Closest candidates are:
│      iterate(::Any) at essentials.jl:853
│      iterate(::Any, !Matched::Any) at essentials.jl:847
│      iterate(!Matched::Core.SimpleVector) at essentials.jl:583
│      ...
│    Stacktrace:
│     [1] start(::Nothing) at ./essentials.jl:878
│     [2] iterate(::Nothing) at ./essentials.jl:853
│     [3] writebodystream(::HTTP.Streams.Stream{HTTP.Messages.Response,HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext}}, ::HTTP.Messages.Request, ::Nothing) at /usr/people/jingpeng/.julia/packages/HTT
P/YjRCz/src/StreamRequest.jl:118
│     [4] writebody(::HTTP.Streams.Stream{HTTP.Messages.Response,HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext}}, ::HTTP.Messages.Request, ::Nothing) at /usr/people/jingpeng/.julia/packages/HTTP/YjRC
z/src/StreamRequest.jl:97
│     [5] (::getfield(HTTP.StreamRequest, Symbol("##2#3")){HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext},HTTP.Messages.Request,Nothing})() at ./task.jl:262                                          
└ @ HTTP.StreamRequest ~/.julia/packages/HTTP/YjRCz/src/StreamRequest.jl:60
test gsdict io: Error During Test at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:7                                                                                                  
  Got exception UndefVarError(:statuscode) outside of a @test
  UndefVarError: statuscode not defined
  Stacktrace:
   [1] #execute#20(::Nothing, ::Bool, ::String, ::Bool, ::Bool, ::Dates.Second, ::Int64, ::Base.Iterators.Pairs{Symbol,String,Tuple{Symbol},NamedTuple{(:fields,),Tuple{String}}}, ::typeof(GoogleCloud.api.
execute), ::GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials}, ::GoogleCloud.api.APIResource, ::GoogleCloud.api.APIMethod, ::String) at /usr/people/jingpeng/.julia/dev/GoogleCloud
/src/api/api.jl:310
   [2] (::getfield(GoogleCloud.api, Symbol("#kw##execute")))(::NamedTuple{(:fields,),Tuple{String}}, ::typeof(GoogleCloud.api.execute), ::GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCred
entials}, ::GoogleCloud.api.APIResource, ::GoogleCloud.api.APIMethod, ::String) at ./none:0
   [3] #call#19(::Base.Iterators.Pairs{Symbol,Any,Tuple{Symbol,Symbol},NamedTuple{(:session, :fields),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials},String}}}, ::GoogleCl
oud.api.APIRoot, ::Symbol, ::Symbol, ::String) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/api/api.jl:218                                                                                           
   [4] (::getfield(GoogleCloud.api, Symbol("#kw#APIRoot")))(::NamedTuple{(:session, :fields),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials},String}}, ::GoogleCloud.api.AP
IRoot, ::Symbol, ::Symbol, ::String) at ./none:0
   [5] #connect!#4(::String, ::Bool, ::Function, ::GoogleCloud.collection.KeyStore{String,Array{UInt8,1}}) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/collection.jl:75                             
   [6] #connect! at ./none:0 [inlined]
   [7] #call#1(::GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials}, ::String, ::Bool, ::Bool, ::Symbol, ::Symbol, ::Type{GoogleCloud.collection.KeyStore{String,Array{UInt8,1}}}, :
:String) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/collection.jl:70
   [8] (::getfield(Core, Symbol("#kw#Type")))(::NamedTuple{(:session, :key_format, :val_format, :empty, :gzip),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials},Symbol,Symbo
l,Bool,Bool}}, ::Type{GoogleCloud.collection.KeyStore{String,Array{UInt8,1}}}, ::String) at ./none:0
   [9] #GSDict#1(::Bool, ::String, ::DataType, ::Type, ::String) at /usr/people/jingpeng/.julia/dev/BigArrays/src/backends/GSDicts.jl:31                                                                   
   [10] GSDict(::String) at /usr/people/jingpeng/.julia/dev/BigArrays/src/backends/GSDicts.jl:26
   [11] macro expansion at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:8 [inlined]                                                                                                  
   [12] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v0.7/Test/src/Test.jl:1079 [inlined]                                                                           
   [13] top-level scope at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:8
   [14] include at ./boot.jl:317 [inlined]
   [15] include_relative(::Module, ::String) at ./loading.jl:1038
   [16] include(::Module, ::String) at ./sysimg.jl:29
   [17] exec_options(::Base.JLOptions) at ./client.jl:239
   [18] _start() at ./client.jl:432
Test Summary:  | Error  Total
test gsdict io |     1      1
ERROR: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:7

joshbode · 2018-10-04T22:13:31Z

Looks like the issue is:

  UndefVarError: statuscode not defined

xiuliren · 2018-10-05T00:28:56Z

I have fixed that error, but get some more.

┌ Warning: Error in @async writebody task                                                                                                                                           │   exception =                                                    
│    MethodError: no method matching iterate(::Nothing)                                                                                                                             │    Closest candidates are:                                                                                                                                                       
│      iterate(::Any) at essentials.jl:853                                                                                                                                          │      iterate(::Any, !Matched::Any) at essentials.jl:847                                                                                                                          
│      iterate(!Matched::Core.SimpleVector) at essentials.jl:583                                                                                                                    │      ...                                                                            
│    Stacktrace:                                                                                                                                                                    │     [1] start(::Nothing) at ./essentials.jl:878
│     [2] iterate(::Nothing) at ./essentials.jl:853
│     [3] writebodystream(::HTTP.Streams.Stream{HTTP.Messages.Response,HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext}}, ::HTTP.Messages.Request, ::Nothing) at /usr/people/jingpeng/.julia/packages/HTTP/YjRCz/src/StreamRequest.jl:118                                                                                                                           
│     [4] writebody(::HTTP.Streams.Stream{HTTP.Messages.Response,HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext}}, ::HTTP.Messages.Request, ::Nothing) at /usr/people/jingpeng/.julia/packages/HTTP/YjRCz/src/StreamRequest.jl:97                                                                                                                                  
│     [5] (::getfield(HTTP.StreamRequest, Symbol("##2#3")){HTTP.ConnectionPool.Transaction{MbedTLS.SSLContext},HTTP.Messages.Request,Nothing})() at ./task.jl:262                  
└ @ HTTP.StreamRequest ~/.julia/packages/HTTP/YjRCz/src/StreamRequest.jl:60

test gsdict io: Error During Test at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:7                                                                          
  Got exception ArgumentError("invalid index: Content-Type of type String") outside of a @test                                                                                     
  ArgumentError: invalid index: Content-Type of type String
  Stacktrace:
   [1] to_index(::String) at ./indices.jl:241
   [2] to_index(::Array{Pair{SubString{String},SubString{String}},1}, ::String) at ./indices.jl:222                                                                                
   [3] to_indices at ./indices.jl:269 [inlined]
   [4] to_indices at ./indices.jl:266 [inlined]                                                                                                                                    
   [5] getindex(::Array{Pair{SubString{String},SubString{String}},1}, ::String) at ./abstractarray.jl:913                                                                          
   [6] macro expansion at ./show.jl:556 [inlined]                                                                                                                                  
   [7] macro expansion at ./logging.jl:311 [inlined]
   [8] #execute#20(::Nothing, ::Bool, ::String, ::Bool, ::Bool, ::Dates.Second, ::Int64, ::Base.Iterators.Pairs{Symbol,String,Tuple{Symbol},NamedTuple{(:fields,),Tuple{String}}}, $:typeof(GoogleCloud.api.execute), ::GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials}, ::GoogleCloud.api.APIResource, ::GoogleCloud.api.APIMethod, ::Strin$
) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/api/api.jl:287
   [9] (::getfield(GoogleCloud.api, Symbol("#kw##execute")))(::NamedTuple{(:debug, :fields),Tuple{Bool,String}}, ::typeof(GoogleCloud.api.execute), ::GoogleCloud.session.GoogleSes$
ion{GoogleCloud.credentials.JSONCredentials}, ::GoogleCloud.api.APIResource, ::GoogleCloud.api.APIMethod, ::String) at ./none:0                                                    
   [10] #call#19(::Base.Iterators.Pairs{Symbol,Any,Tuple{Symbol,Symbol,Symbol},NamedTuple{(:session, :fields, :debug),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credentia$
s.JSONCredentials},String,Bool}}}, ::GoogleCloud.api.APIRoot, ::Symbol, ::Symbol, ::String) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/api/api.jl:218                      
   [11] (::getfield(GoogleCloud.api, Symbol("#kw#APIRoot")))(::NamedTuple{(:session, :fields, :debug),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentia$
s},String,Bool}}, ::GoogleCloud.api.APIRoot, ::Symbol, ::Symbol, ::String) at ./none:0
   [12] #connect!#4(::String, ::Bool, ::Bool, ::Function, ::GoogleCloud.collection.KeyStore{String,Array{UInt8,1}}) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/collection.j$
:77
   [13] #connect! at ./none:0 [inlined]
   [14] #call#1(::GoogleCloud.session.GoogleSession{GoogleCloud.credentials.JSONCredentials}, ::String, ::Bool, ::Bool, ::Symbol, ::Symbol, ::Bool, ::Type{GoogleCloud.collection.K$
yStore{String,Array{UInt8,1}}}, ::String) at /usr/people/jingpeng/.julia/dev/GoogleCloud/src/collection.jl:71                                                                      
   [15] (::getfield(Core, Symbol("#kw#Type")))(::NamedTuple{(:session, :key_format, :val_format, :empty, :gzip, :debug),Tuple{GoogleCloud.session.GoogleSession{GoogleCloud.credent$
als.JSONCredentials},Symbol,Symbol,Bool,Bool,Bool}}, ::Type{GoogleCloud.collection.KeyStore{String,Array{UInt8,1}}}, ::String) at ./none:0                                         
   [16] #GSDict#1(::Bool, ::String, ::DataType, ::Type, ::String) at /usr/people/jingpeng/.julia/dev/BigArrays/src/backends/GSDicts.jl:31                                          
   [17] GSDict(::String) at /usr/people/jingpeng/.julia/dev/BigArrays/src/backends/GSDicts.jl:26                                                                                   
   [18] macro expansion at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:8 [inlined]                                                                          
   [19] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v0.7/Test/src/Test.jl:1079 [inlined]                                                   
   [20] top-level scope at /usr/people/jingpeng/.julia/dev/BigArrays/test/backends/GSDicts.jl:8                                                                                    
   [21] include at ./boot.jl:317 [inlined]                                                                                                                                         
   [22] include_relative(::Module, ::String) at ./loading.jl:1038

xiuliren · 2018-10-18T20:39:49Z

@samoconnor @quinnj There are some errors related with HTTP. It probably is a bug of this package rather than HTTP.
could you please help to take a look at the errors? any idea will be appreciated.

samoconnor · 2018-10-18T21:08:14Z

getindex(::Array{Pair{SubString{String},SubString{String}},1}, ::String)

The stack trace says you're calling getindex(x, i) (x[i]) on a Vector{Pair} with a String as an index.

https://juliaweb.github.io/HTTP.jl/latest/index.html#HTTP.Messages.header

https://juliaweb.github.io/HTTP.jl/latest/index.html#HTTP.Messages.hasheader

xiuliren · 2018-10-31T21:27:37Z

I have fixed the bugs, tests passed. I have only tested with Storage backend and KeyStore functions though.

xiuliren · 2018-10-31T21:34:00Z

@StefanKarpinski I would like to register this upgrade to METADATA.jl using attobot, but I can not set it up since I do not have the permission. Could you please help to set it up or just give me the permission?

There is an issue from attobot complaining the tagging link is not correct, since it was migrated from @joshbode 's repo.
#23

xiuliren · 2018-10-31T21:41:29Z

I also can not edit the documentation link which is invalid and outdated.

joshbode · 2018-10-31T22:50:09Z

Thanks for all your effort @jingpengw!

I also am not able to edit that link for some reason...

femtocleaner bot and others added 4 commits August 8, 2018 12:42

Fix deprecations

72f1e13

upgrade to 0.7

e9bf4f2

Merge pull request #3 from jingpengw/fbot/deps

66f7604

Fix deprecations

update, the

f6a9b32

joshbode reviewed Aug 13, 2018

View reviewed changes

joshbode mentioned this pull request Aug 13, 2018

changes for julia 0.7 #21

Closed

update travis and appveyor; still not work;

00ab7d9

fix statuscode error

f31ce78

xiuliren added 3 commits October 31, 2018 15:37

add tests

ca5ad5b

fix api bug to use HTTP package

f673ebb

remove the auto test for storage since it requires authentication

0a2cfc0

xiuliren changed the title ~~[WIP] upgrade to Julia 0.7; switch to HTTP.jl~~ Upgrade to Julia 0.7; switch to HTTP.jl Oct 31, 2018

xiuliren merged commit 6cc36fd into JuliaCloud:master Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Julia 0.7; switch to HTTP.jl #20

Upgrade to Julia 0.7; switch to HTTP.jl #20

xiuliren commented Aug 10, 2018

xiuliren commented Aug 10, 2018

joshbode commented Aug 10, 2018

joshbode commented Aug 13, 2018

joshbode Aug 13, 2018

xiuliren commented Aug 14, 2018

xiuliren commented Oct 4, 2018

joshbode commented Oct 4, 2018

xiuliren commented Oct 5, 2018

xiuliren commented Oct 18, 2018

samoconnor commented Oct 18, 2018

xiuliren commented Oct 31, 2018

xiuliren commented Oct 31, 2018 •

edited

Loading

xiuliren commented Oct 31, 2018

joshbode commented Oct 31, 2018

Upgrade to Julia 0.7; switch to HTTP.jl #20

Upgrade to Julia 0.7; switch to HTTP.jl #20

Conversation

xiuliren commented Aug 10, 2018

xiuliren commented Aug 10, 2018

joshbode commented Aug 10, 2018

joshbode commented Aug 13, 2018

joshbode Aug 13, 2018

Choose a reason for hiding this comment

xiuliren commented Aug 14, 2018

xiuliren commented Oct 4, 2018

joshbode commented Oct 4, 2018

xiuliren commented Oct 5, 2018

xiuliren commented Oct 18, 2018

samoconnor commented Oct 18, 2018

xiuliren commented Oct 31, 2018

xiuliren commented Oct 31, 2018 • edited Loading

xiuliren commented Oct 31, 2018

joshbode commented Oct 31, 2018

xiuliren commented Oct 31, 2018 •

edited

Loading