Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass options when sending messages to SQS queue #16

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

mattBrzezinski
Copy link
Member

Based off of #13
Updated version of #10 since I do not have permissions to push to that fork.


Added the option to pass options to sqs_send_message(), this is needed for Fifo Queues as they require MessageGroupId and MessageDeduplicationId.

@mattBrzezinski
Copy link
Member Author

The diff looks strange since I have based my changes off of another branch that is currently in CR.

To see a better looking diff go, here

@iamed2
Copy link
Member

iamed2 commented Dec 16, 2019

Are you going to merge this into MB/refactor-testing or master?

@mattBrzezinski
Copy link
Member Author

Are you going to merge this into MB/refactor-testing or master?

I was hoping that #13 gets merged in first, then rebase this branch once it's in.

@mattBrzezinski mattBrzezinski merged commit 0d7d06c into master Dec 17, 2019
@mattBrzezinski
Copy link
Member Author

@tk3369 v0.6.2 will be released shortly, you can follow along here.

@mattBrzezinski mattBrzezinski deleted the MB/message-options branch June 23, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants