Fixed S3 Multi-Part Upload #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattBrzezinski
force-pushed
the
MB/multi-part
branch
from
92f3045 to
92b4266
Compare
|
I've been playing with this and it works fine for simple uploads. However, larger uploads quickly run into connection errors from HTTP.jl. A bunch of them are similar to JuliaWeb/HTTP.jl#517, so I've spent some time debugging that, but unfortunately, that doesn't appear sufficient. Shouldn't block this merge of course. |
|
Ok, the other errors I ended up with were just expirations of the access tokens, though HTTP.jl really didnt't like that. |
Keno
approved these changes
Apr 15, 2020
mattBrzezinski
force-pushed
the
MB/multi-part
branch
from
92b4266 to
b280feb
Compare
iamed2
requested changes
Apr 15, 2020
iamed2
approved these changes
Apr 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends On: JuliaCloud/AWSCore.jl#117
Resolves: #84
Overview
Previously
AWSCore.jlwas not returning headers for a request and thes3_upload_part()would break. Changes have been made in that package to return response headers when the kwargreturn_headers=trueis passed in.This merge request is just updating the
s3_upload_part()to properly pull the returnedETagfrom Amazon, as well as include a test for multi-part uploading.