Added capabilities to use different S3 backed storages other than AWS' #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a special casing for AWS S3 service defintiions to allow for the usage of different backed storages.
Updated Services.jl with new API definitions as it hasn't been updated since 2018-08-01.
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
99: Added capabilities to use different S3 backed storages other than AWS' r=mattBrzezinski a=mattBrzezinski I do not have permissions to push on @meggart fork, to get this into `master` in time for them I've just created another CR so that I can push it through. Same changes as: #82 Co-authored-by: Fabian Gans <[email protected]> Co-authored-by: Fabian Gans <[email protected]> Co-authored-by: Matt Brzezinski <[email protected]>
This was referenced Dec 3, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
99: Added capabilities to use different S3 backed storages other than AWS' r=mattBrzezinski a=mattBrzezinski I do not have permissions to push on @meggart fork, to get this into `master` in time for them I've just created another CR so that I can push it through. Same changes as: #82 Co-authored-by: Fabian Gans <[email protected]> Co-authored-by: Fabian Gans <[email protected]> Co-authored-by: Matt Brzezinski <[email protected]>
Build succeeded |
|
This is great, thanks. Would you mind to tag a new release, so that my downstream packages can depend on this change? |
|
Not sure if you've recently updated, but the release went through yesterday. |
|
Yes, I have seen it yesterday. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have permissions to push on @meggart fork, to get this into
masterin time for them I've just created another CR so that I can push it through.Same changes as: #82