Flush I/O before reading from test file #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
I'll merge this once the CI passes as it's a trivial change |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 28, 2021
463: Flush I/O before reading from test file r=omus a=omus This failure occurred when running the CI tests on #453: ``` high-level s3: Test Failed at /Users/runner/work/AWS.jl/AWS.jl/test/AWS.jl:844 Expression: read(f, String) == body Evaluated: "" == "sample-file-body" Stacktrace: [1] (::var"#41#43"{String, String, String})(f::String, io::IOStream) @ Main ~/work/AWS.jl/AWS.jl/test/AWS.jl:844 [2] mktemp(fn::var"#41#43"{String, String, String}, parent::String) @ Base.Filesystem ./file.jl:703 [3] mktemp(fn::Function) @ Base.Filesystem ./file.jl:701 [4] macro expansion @ ~/work/AWS.jl/AWS.jl/test/AWS.jl:842 [inlined] [5] macro expansion @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined] [6] macro expansion @ ~/work/AWS.jl/AWS.jl/test/AWS.jl:801 [inlined] [7] macro expansion @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined] [8] top-level scope @ ~/work/AWS.jl/AWS.jl/test/AWS.jl:800 WARNING: replacing module S3. WARNING: replacing module S3. Backend: HTTPBackend: Test Failed at /Users/runner/work/AWS.jl/AWS.jl/test/minio.jl:45 Expression: read(f, String) == "Hi from Minio" Evaluated: "" == "Hi from Minio" Stacktrace: [1] (::var"#162#163")(f::String, io::IOStream) @ Main ~/work/AWS.jl/AWS.jl/test/minio.jl:45 [2] mktemp(fn::var"#162#163", parent::String) @ Base.Filesystem ./file.jl:703 [3] mktemp(fn::Function) @ Base.Filesystem ./file.jl:701 [4] top-level scope @ ~/work/AWS.jl/AWS.jl/test/minio.jl:43 [5] include @ ./client.jl:444 [inlined] [6] macro expansion @ ~/work/AWS.jl/AWS.jl/test/runtests.jl:66 [inlined] [7] macro expansion @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1226 [inlined] [8] macro expansion @ ~/work/AWS.jl/AWS.jl/test/runtests.jl:59 [inlined] [9] macro expansion @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined] [10] top-level scope @ ~/work/AWS.jl/AWS.jl/test/runtests.jl:52 ``` – https://github.com/JuliaCloud/AWS.jl/runs/3726649750 As it turns out I already noticed this test as part of #458 but [originally thought it was a minor difference with `AWS.Response`](#458 (comment)). It turns out that it is just a stochastic when using the HTTPBackend. Co-authored-by: Curtis Vogt <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
That's it. I'm going rogue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failure occurred when running the CI tests on #453:
– https://github.com/JuliaCloud/AWS.jl/runs/3726649750
As it turns out I already noticed this test as part of #458 but originally thought it was a minor difference with
AWS.Response. It turns out that it is just a stochastic when using the HTTPBackend.