Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added formatting for auto-generation #425

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

mattBrzezinski
Copy link
Member

I added in auto-formatting for code in #423, this will become problematic going forward when code is auto-generated each evening as you'll need to step through accepting all changes as it is breaking BlueStyle.

This PR address' that by adding in an additional step to the update_apis.yml action to automatically format the code before creating the merge request.

@fchorney
Copy link

fchorney commented Aug 13, 2021

does #423 check for code style, or try and format the code itself in an action?

Edit: I didn't see the reviewdog/action-suggester@v1 part which will make suggestions for code style on the PR. This answers my question

@mattBrzezinski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 13, 2021

@bors bors bot merged commit 6ce7fe5 into master Aug 13, 2021
@bors bors bot deleted the MB/format-auto-generation branch August 13, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants