AssumeRole parse response properly #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morris25
approved these changes
Feb 11, 2021
| @@ -562,13 +562,13 @@ function _aws_get_role(role::AbstractString, ini::Inifile) | |||
| aws_config=config | |||
| ) | |||
|
|
|||
| role_creds = role["Credentials"] | |||
| role_creds = role["AssumeRoleResult"]["Credentials"] | |||
There was a problem hiding this comment.
Are there some docs that we can link to that keep track of what format this takes?
There was a problem hiding this comment.
Yes, I can add in a test for this will need to update the stack as well. I'll get up a commit shortly. |
Ran into some issues when creating a test for this, currently don't have the time to look into it. I think this should go in to un-block our private CI's running into issues. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 12, 2021
281: AssumeRole parse response properly r=mattBrzezinski a=mattBrzezinski
# Problem
We are seeing the following error on our CI machines:
```julia
ERROR: LoadError: InitError: KeyError: key "Credentials" not found
Stacktrace:
[1] getindex(::OrderedCollections.LittleDict{Union{String, Symbol},Any,Array{Union{String, Symbol},1},Array{Any,1}}, ::String) at ./abstractdict.jl:492
[2] _aws_get_role(::String, ::IniFile.Inifile) at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWSCredentials.jl:565
[3] dot_aws_config(::Nothing) at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWSCredentials.jl:449
[4] (::AWS.var"#12#15")() at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWSCredentials.jl:154
[5] AWS.AWSCredentials(; profile::Nothing) at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWSCredentials.jl:163
[6] AWS.AWSConfig() at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWSConfig.jl:18
[7] #global_aws_config#21 at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWS.jl:47 [inlined]
[8] global_aws_config at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWS/SALZq/src/AWS.jl:46 [inlined]
[9] AWSS3.S3Path(::String) at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/AWSS3/H9WJU/src/s3path.jl:83
[10] init(::Type{{REDACTED}.{REDACTED}}) at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/{REDACTED}/p9Xwj/src/{REDACTED}.jl:74
[11] __init__() at /Users/admin/builds/f75a2375/0/invenia/{REDACTED}.jl.tmp/depot/packages/{REDACTED}/p9Xwj/src/{REDACTED}.jl:24
[12] _include_from_serialized(::String, ::Array{Any,1}) at ./loading.jl:697
[13] _require_from_serialized(::String) at ./loading.jl:749
[14] _require(::Base.PkgId) at ./loading.jl:1040
[15] require(::Base.PkgId) at ./loading.jl:928
[16] require(::Module, ::Symbol) at ./loading.jl:923
[17] include(::String) at ./client.jl:457
[18] top-level scope at none:6
during initialization of module {REDACTED}
```
# Solution
AWS does not return the credentials when assuming a role at the top-level, but instead it's nested in the `AssumeRoleResult` key.
Co-authored-by: Matt Brzezinski <[email protected]>
|
Logged an issue for the bors callback to merge not working, #283 |
|
@mattBrzezinski can you add a test with |
I do actually want to dig into this at some point as I'm really curious why this isn't working. |
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are seeing the following error on our CI machines:
Solution
AWS does not return the credentials when assuming a role at the top-level, but instead it's nested in the
AssumeRoleResultkey.