Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit debug logs on retry? #514

Open
ericphanson opened this issue Nov 12, 2021 · 0 comments
Open

Emit debug logs on retry? #514

ericphanson opened this issue Nov 12, 2021 · 0 comments

Comments

@ericphanson
Copy link
Member

In my use of AWS.jl, I would find it interesting to know what kinds of network issues we are hitting and how frequently they occur. We could support this by emitting debug logs (e.g. @debug "AWS.jl retry" reason=... or something). This wouldn't be spammy since the default console logger drops them, but it would allow setting a custom logger or changing the global log-level to surface them.

bors bot added a commit that referenced this issue Mar 20, 2023
549: Add debug logging messages on retry r=mattBrzezinski a=ericphanson

Closes #514

Based on #548

The logging messages are structured so the string is a human-readable summary of the message, and then the fields are  more structured for later analysis, e.g. `retry::Bool`, `reason::String`, etc. Additionally, the id of the log message will be useful for aggregation.

Co-authored-by: Eric Hanson <[email protected]>
Co-authored-by: Matt Brzezinski <[email protected]>
bors bot added a commit that referenced this issue Mar 20, 2023
549: Add debug logging messages on retry r=mattBrzezinski a=ericphanson

Closes #514

Based on #548

The logging messages are structured so the string is a human-readable summary of the message, and then the fields are  more structured for later analysis, e.g. `retry::Bool`, `reason::String`, etc. Additionally, the id of the log message will be useful for aggregation.

Co-authored-by: Eric Hanson <[email protected]>
Co-authored-by: Matt Brzezinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants