Skip to content

Commit

Permalink
fixup! Test isopen on response_stream
Browse files Browse the repository at this point in the history
  • Loading branch information
omus committed Sep 29, 2021
1 parent f676525 commit d6aeacc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/issues.jl
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ try
if AWS.DEFAULT_BACKEND[] isa AWS.HTTPBackend
@test !isopen(stream)
else
@test !isopen(stream)
@test_broken isopen(stream)
end

stream = Base.BufferStream()
Expand Down
5 changes: 4 additions & 1 deletion test/minio.jl
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ try
@test sort(getindex.(objs_prefix["Contents"], "Key")) == ["empty", "myobject"]
@test objs_prefix["CommonPrefixes"]["Prefix"] == "foo/"

# Duplicated testset from "test/issues.jl". Useful for testing outside the CI. Ideally,
# the tests should be revised such that local testing works without having to duplicate
# testsets.
@testset "issue 466" begin
file_name = "hang.txt"

Expand All @@ -82,7 +85,7 @@ try
if AWS.DEFAULT_BACKEND[] isa AWS.HTTPBackend
@test !isopen(stream)
else
@test !isopen(stream)
@test_broken isopen(stream)
end

stream = Base.BufferStream()
Expand Down

0 comments on commit d6aeacc

Please sign in to comment.