-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable x86_64-linux-gnu
packager
#42
Conversation
cee1350
to
7fa1465
Compare
Rootfs hash mismatch? |
e607bd1
to
c0b9139
Compare
if [[ "${IS_RR?}" == "yes" ]]; then | ||
export JULIA_CMD_FOR_TESTS="$${JULIA_BINARY:?} .buildkite/utilities/rr/rr_capture.jl $${JULIA_BINARY:?}" | ||
export NCORES_FOR_TESTS="parse(Int, ENV[\"JULIA_RRCAPTURE_NUM_CORES\"])" | ||
export JULIA_NUM_THREADS=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we try doing export JULIA_NUM_THREADS=2
for the rr job?
2b78032
to
070072b
Compare
What commit of Julia are you using? Perhaps the fork is behind. |
🤦 I both added and removed |
462e932
to
a224a08
Compare
Personally, I think that "packaging" is too coarse of a group. I would suggest that we have five groups:
And here are the jobs that would live inside each group:
I think this finds a good balance between being too coarse and being too granular. Also I think we should rename "packaging" to "build". |
The other option would be to have nine groups:
I would be fine with either the five groups (as listed above), or the nine groups. I have a slight preference for the five groups. |
One of the reasons that I have for wanting to group by OS is that it makes it easier to see what's going on with the agents. For example, if every PR is green on all OSs except for Windows, and the Windows groups are all yellow on all PRs, then we know that the Windows queue is really backed up. |
3762dd5
to
351975b
Compare
I think that the namespace for keys is shared among all entities. So if you have a group with key |
85ae354
to
a591960
Compare
Instead of these terrible whitespace-delimited tables that I created, should we just bite the bullet and use TOML/YAML/JSON? |
We have Julia available, so we can just use the TOML stdlib. Most entries won't be very verbose, because for most entries we'll just omit most keys, and the default values will get used. |
I like the terrible tables; it allows me to implement scary features like default values and whatnot. 😈 If we jump ship, I think we can use the new build matrix functionality that buildkite is cooking up. |
18a1fd8
to
0133492
Compare
Can you take the remaining three ungrounded checks and either put them into an existing group, or make a |
I would just rename |
1a3b4e1
to
7983d53
Compare
Use new rootfs image with custom-built glibc and gcc version.
7983d53
to
57c60a4
Compare
Alright, we're going to call this good for now. There are some issues still:
I think this is sufficient to deploy to the main repository. It's better organized, and importantly, it should reduce our CI burden significantly by reducing the number of times we run the full test suite by a factor of 6. 😳 |
No description provided.