Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check fails #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check fails #5

wants to merge 2 commits into from

Conversation

simonbyrne
Copy link
Member

No description provided.

@ararslan
Copy link
Member

Hm, seems to be working as expected.

@simonbyrne
Copy link
Member Author

@ararslan that was before I enabled coverage

@ararslan
Copy link
Member

ararslan commented Sep 26, 2018

If you look at https://staging.travis-ci.org/JuliaCI/TravisTest.jl/jobs/728738, it seems that the tests failed but the coverage steps still ran. (They just happened to also fail.)

@simonbyrne
Copy link
Member Author

Wait, why is the coverage stuff failing!?

@simonbyrne
Copy link
Member Author

Ah, it's because we're running on Travis staging!

@simonbyrne simonbyrne closed this Nov 7, 2018
@simonbyrne simonbyrne reopened this Nov 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ffc06...593a550. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants