Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .jlt instead of .jl for template files #481

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

fredrikekre
Copy link
Member

This patch changes the file extension of Julia template files from .jl to .jlt. The motivation for this is tooling that assume these are (valid) julia source files based on the .jl extension.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (a007c9e) to head (813835a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          24       24           
  Lines         742      742           
=======================================
  Hits          700      700           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Collaborator

I think this makes sense.
Most syntax highlighting tools etc (that are ok with broken code) still are not that useful on the template files.
And the language can always be set manually.

Do you have merge rights?

@oxinabox
Copy link
Collaborator

oxinabox commented Aug 23, 2024

This CI error is real:
https://github.com/JuliaCI/PkgTemplates.jl/actions/runs/10521345275/job/29151850911?pr=481#step:7:137

(One annoying thing about this repo is we do do different tests on different versions of julia)

This patch changes the file extension of Julia template files from .jl
to .jlt. The motivation for this is tooling that assume these are
(valid) julia source files based on the .jl extension.
@fredrikekre
Copy link
Member Author

This CI error is real:

Fixed, didn't show up locally (on the same Julia version).

Do you have merge rights?

Looks like it.

oxinabox
oxinabox previously approved these changes Aug 23, 2024
@oxinabox
Copy link
Collaborator

LGTM
Probably bump as a nonbreaking change so you can tag a release after you merge

@fredrikekre fredrikekre merged commit 6cb59aa into JuliaCI:master Sep 10, 2024
17 checks passed
@fredrikekre fredrikekre deleted the fe/jlt branch September 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants