Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov secret token to CI template #458

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Add codecov secret token to CI template #458

merged 2 commits into from
Feb 8, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Feb 7, 2024

No description provided.

@gdalle
Copy link
Collaborator Author

gdalle commented Feb 7, 2024

@DilumAluthge could it be that this fails because you added an org token and so we need to delete the repo token?

Copy link
Collaborator

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge once working

@gdalle
Copy link
Collaborator Author

gdalle commented Feb 8, 2024

We didn't get a coverage report on this PR, and the Codecov CI log says invalid token. Gonna try deleting the repo token to see if using the org-wide solves it

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c354577) 94.33% compared to head (26fe6f9) 94.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          24       24           
  Lines         742      742           
=======================================
  Hits          700      700           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator Author

gdalle commented Feb 8, 2024

there we go

@gdalle gdalle merged commit 6f6c392 into master Feb 8, 2024
17 checks passed
@gdalle gdalle deleted the gd/codecov4 branch February 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants