-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repo argument to makedocs #450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 24 24
Lines 742 742
=======================================
Hits 696 696
Misses 46 46 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Avoids the following warning by letting Documenter infer the repository instead of giving
repo::String
:The alternative would be to provide an explicit
Remotes.GitHub
,Remotes.GitLab
orRemotes.URL
depending on the host (see the release notes https://documenter.juliadocs.org/v1.0.0/release-notes/).Not sure which is best.
Is this enough to fix #430?