Do not truncate ".jl" from generated package directory #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
===========================================
- Coverage 93.58% 71.86% -21.73%
===========================================
Files 23 23
Lines 686 686
===========================================
- Hits 642 493 -149
- Misses 44 193 +149
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nickrobinson251
approved these changes
Aug 29, 2023
| """ | ||
| function pkg_name_from_pkg_dir(pkg_dir::AbstractString) | ||
| pkg = basename(pkg_dir) | ||
| return endswith(pkg, ".jl") ? pkg[1:end-3] : pkg |
There was a problem hiding this comment.
we could use chopsuffix (but idk what Julia version that was introduced in, so maybe we can't)
Suggested change
| return endswith(pkg, ".jl") ? pkg[1:end-3] : pkg | |
| return chopsuffix(pkg, ".jl") |
There was a problem hiding this comment.
TIL! Looks like it shows up in 1.8...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353.
Probably non-breaking, as I don't see it explicitly documented anywhere that a ".jl" suffix would be removed when generating a package.
Updated approach respects user input:
Template("MyPkg.jl")will create directory "MyPkg.jl", whileTemplate("MyPkg")will generate directory "MyPkg". Contents of these two packages will be otherwise identical.