Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagBot template #407

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Update TagBot template #407

merged 2 commits into from
Jun 6, 2023

Conversation

SamuraiAku
Copy link
Contributor

Resolves #403

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #407 (5465a91) into master (602d49e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          22       22           
  Lines         667      667           
=======================================
  Hits          630      630           
  Misses         37       37           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oxinabox
Copy link
Collaborator

oxinabox commented Jun 1, 2023

Awesome.
Note the julia 1.7.2 tests are failing.
That is likely because we only do testing of reference file and interative mode in julia 1.7.2

So we need julia 1.7.2 to pass before we can merge this

@SamuraiAku
Copy link
Contributor Author

@oxinabox Did you want me to update the tests? Can you give me some pointers as to what files need to be changed? I am not familiar with your test setup.

@SamuraiAku
Copy link
Contributor Author

I managed to figure out what files to update. All CI tests are passing now.

@oxinabox oxinabox merged commit ae960bc into JuliaCI:master Jun 6, 2023
@oxinabox
Copy link
Collaborator

oxinabox commented Jun 6, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagBot template is out of date
2 participants