Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make GitHubActions a default plugin #399

Merged
merged 2 commits into from
May 15, 2023

Conversation

musoke
Copy link
Contributor

@musoke musoke commented May 12, 2023

Fixes #357

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #399 (4f3920e) into master (5cc1711) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          22       22           
  Lines         667      667           
=======================================
  Hits          630      630           
  Misses         37       37           
Impacted Files Coverage Δ
src/template.jl 97.65% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oxinabox oxinabox merged commit 269e55d into JuliaCI:master May 15, 2023
@ericphanson
Copy link
Contributor

Was this breaking? I had some code that called

exp_template = Template(;
                        authors=["Beacon Biosignals, Inc"],
                        dir=parent_subdir,
                        julia=v"1.8.5",
                        plugins=[ProjectFile(; version=v"0.0.1"),
                                 SrcDir(; file=src_template),
                                 !Tests, !Readme, !Git, !License, !CompatHelper, !TagBot])

and now it errors with

ERROR: LoadError: GitHubActions: Git hosting service username is required, set one with keyword `user="<username>"`

(I will just pin 0.7.34 until I have a chance to update it, so I don't really mind that much, but maybe one should be careful w/ changing defaults that add requirements)

@musoke
Copy link
Contributor Author

musoke commented Jun 15, 2023

It certainly wasn't meant to be breaking, but it does seem that you have identified a breakage. I don't think the tests check any cases without these variables set.

@oxinabox
Copy link
Collaborator

Possibly we should revert this?

Maybe this is a good excuse to go to v1.0.0

@musoke
Copy link
Contributor Author

musoke commented Jun 16, 2023

I will defer to you on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GitHub Actions CI a default plugin
3 participants