-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a template and plugin for PkgBenchmarks #261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 92.59% 92.08% -0.52%
==========================================
Files 19 20 +1
Lines 540 543 +3
==========================================
Hits 500 500
- Misses 40 43 +3
Continue to review full report at Codecov.
|
bumping this, seems like a good idea |
solves #86 |
I'd like to take this PR over the finish line by adding tests. @christopher-dG @DilumAluthge or @vchuravy can someone add me to the org so that I'm allowed to push to this branch? |
MIght be better to recommend PkgBenchmarks.jl? |
Yes that's actually what is done in the code but I can't change the PR title |
Probably best to just open a new PR and cherry-pick the original change. |
Also possible of course, I just wanted @anandijain to be recognized as a contributor, which won't happen if I copy-paste their code in a new PR :) |
there are other PRs I could also push further, that's why I'd love access to the repo but I understand if you prefer not to hand it out |
I only have access due to being a org-admin; I will defer to @oxinabox she seems to be the most active developer here. |
TODO:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 92.91% 92.94% +0.02%
==========================================
Files 23 24 +1
Lines 734 737 +3
==========================================
+ Hits 682 685 +3
Misses 52 52 ☔ View full report in Codecov by Sentry. |
Merging even though the to-do list is incomplete, because this is functional as is |
I think some folks may find this useful.
Feel free to close if unnecessary.
Also I think this might conflict with the Configurations.jl PR.