Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some GitLab URL issues #157

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Fix some GitLab URL issues #157

merged 1 commit into from
Apr 18, 2020

Conversation

christopher-dG
Copy link
Member

@christopher-dG christopher-dG commented Apr 17, 2020

Closes #156
Closes #155

Thanks for the reports @judober! Always good to get feedback on the less-frequently used parts like GitLab support. Could you test this out and confirm that it does what you expect! (you can use ] add PkgTemplates#cdg/gitlab-urls to get this branch with Pkg)

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #157 into master will decrease coverage by 1.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   91.98%   90.36%   -1.62%     
==========================================
  Files          17       17              
  Lines         337      353      +16     
==========================================
+ Hits          310      319       +9     
- Misses         27       34       +7     
Impacted Files Coverage Δ
src/plugins/ci.jl 80.88% <ø> (-10.79%) ⬇️
src/plugins/documenter.jl 80.55% <ø> (-4.30%) ⬇️
src/plugins/develop.jl 66.66% <0.00%> (-33.34%) ⬇️
src/plugins/tests.jl 94.11% <0.00%> (-5.89%) ⬇️
src/template.jl 100.00% <0.00%> (ø)
src/plugins/git.jl 93.33% <0.00%> (+4.69%) ⬆️
src/plugin.jl 94.44% <0.00%> (+5.55%) ⬆️
src/plugins/project_file.jl 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f276d58...3b1383b. Read the comment docs.

@judober
Copy link

judober commented Apr 18, 2020

Well, I cannot use it as before because interactive_template() apparently has changed.
I now get:

ERROR: ArgumentError: Git: Git hosting service username is required, set one with keyword `user="<username>"`

Trying t = interactive_template(user="name") results in

ERROR: MethodError: no method matching interactive_template(; user="name")

As interactive_template is apparently deprecated, I also tried the suggested t = Template(; interactive = true, user="name") which gives me:

┌ Warning: Unrecognized keywords were supplied, see the documentation for help
│   kwargs =
│    Dict{Symbol,Any} with 1 entry:
│      :interactive => true
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/zz7bJ/src/template.jl:100

@christopher-dG
Copy link
Member Author

Oh right, I just kind of assume people use master branch now. Oops! Can you use the Template(...) constructor instead?

@judober
Copy link

judober commented Apr 18, 2020

Ok, it it fixed thanks!

I'm just wondering if I can get the pages for the documentation to work too...
I think the path there is also specific for gitlab.io but I'm not sure what would be the correct version.

Btw: I got this during compilation of PkgTemplates:

WARNING: using PkgTemplates.Documenter in module Main conflicts with an existing identifier.

@christopher-dG
Copy link
Member Author

Yeah there's a TODO to deal with custom GitLab Pages URLs, but because the URL can technically be anything I think we'd have to add a new field to Documenter which feels clunky right now, so I'm gonna wait and think about it some more.

And I've realized that currently the Documenter plugin and Documenter package can't coexist in the same Julia session, but I don't think I see that as too much of a problem because the situation where as user creates a new package and builds documentation in the same session seems pretty rare. If I get a bunch of user complaints about it then I'd probably change it to Docs.

@christopher-dG christopher-dG merged commit ad0c012 into master Apr 18, 2020
@christopher-dG christopher-dG deleted the cdg/gitlab-urls branch April 18, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLabCI "Build Status" has wrong path GitLabCI badges don't recognise hosting service
2 participants