Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg.develop new packages in the Documenter manifest #143

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

christopher-dG
Copy link
Member

Part 2 of #139

Is this (dev ..) the right thing to do here? It seems legit but I'm not quite sure.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #143 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   93.61%   93.75%   +0.13%     
==========================================
  Files          17       17              
  Lines         329      384      +55     
==========================================
+ Hits          308      360      +52     
- Misses         21       24       +3     
Impacted Files Coverage Δ
src/plugin.jl 93.65% <0.00%> (-0.29%) ⬇️
src/template.jl 100.00% <0.00%> (ø) ⬆️
src/PkgTemplates.jl 100.00% <0.00%> (ø) ⬆️
src/plugins/tagbot.jl 100.00% <0.00%> (ø) ⬆️
src/plugins/compat_helper.jl 100.00% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594e7e5...90f2b42. Read the comment docs.

Copy link
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopher-dG christopher-dG merged commit dd025be into master Mar 9, 2020
@christopher-dG christopher-dG deleted the cdg/docsdev branch March 9, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants