Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC clean-ups. #196

Merged
merged 1 commit into from
Jan 7, 2025
Merged

NFC clean-ups. #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/jobs/PkgEvalJob.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ function process_results!(job::PkgEvalJob, builds::Dict, all_tests::DataFrame, r
node = myid()
cfg = submission(job).config

nodelog(cfg, node, "proccessing results...")
nodelog(cfg, node, "processing results...")
for (whichbuild, build) in builds
tests = all_tests[(all_tests[!, :configuration] .== whichbuild), :]
results[whichbuild] = tests
Expand Down Expand Up @@ -522,7 +522,7 @@ function process_results!(job::PkgEvalJob, builds::Dict, all_tests::DataFrame, r
end
end
end
nodelog(cfg, node, "finished proccessing results")
nodelog(cfg, node, "finished processing results")
end

########################
Expand Down Expand Up @@ -557,6 +557,7 @@ function test_julia!(job::PkgEvalJob, builds::Dict, base_configs::Dict, results:

# run tests
all_tests = withenv("CI" => true) do
# the CI env var changes PkgEval's progress reporting
cpus = mycpus(submission(job).config)
results["duration"] = @elapsed if pkgs !== nothing
tests = PkgEval.evaluate(configs, pkgs; ninstances=length(cpus), blacklist)
Expand Down Expand Up @@ -648,6 +649,7 @@ function test_package!(job::PkgEvalJob, builds::Dict, base_configs::Dict, result

# run tests
all_tests = withenv("CI" => true) do
# the CI env var changes PkgEval's progress reporting
cpus = mycpus(submission(job).config)
results["duration"] = @elapsed if pkgs !== nothing
tests = PkgEval.evaluate(configs, pkgs; ninstances=length(cpus), blacklist)
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ primary_commit = GitHub.commits(repo; auth, page_limit=1)[1][10]
against_commit = GitHub.commits(repo; auth, page_limit=1)[1][11]
primary = BuildRef(repo, primary_commit.sha, primary_commit.commit.committer.date)
against = BuildRef(repo, against_commit.sha, against_commit.commit.committer.date)
config = Config("user", Dict(Any => [getpid()]), auth, "test");
config = Config("user", Dict(Any => [getpid()]), auth, "test")
tagpred = "ALL && !(\"tag1\" || \"tag2\")"
pkgsel = ["Example"]

Expand Down
Loading