-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mechanism for excluding files and lines. #55
Conversation
Neat! What do you think @timholy ? |
Seems worth having, thanks @dcjones. I'll be greedy, though, and suggest tests and documentation. |
I'd also like that, but I'll also settle for just merging if thats too much bandwidth right now. Something in the README would be good enough. I sense this is the start of something bigger though - a |
I'll add some tests and documentation later. This isn't urgent for me, I just have some generated code that I feel is going to unfairly penalize my coverage.
I would like that, and going even further I'd like it if |
+1 to a merge (ref: https://groups.google.com/d/msg/julia-users/OLEbyA_-43c/P3EzEU5AJQAJ). Thank you. |
@sbromberger well you/me/@dcjones would need to rebase. If you are using Codecov, you can manually exclude files on the website. |
I'm using Coveralls. I guess I could try to rebase this. |
I'm less keen on merging this than I was previously, as I think it makes the package substantially more complex than I think anyone is willing to maintain right now. Or if it is added, it is not documented and can be broken at any time, which the goal of getting a more standardized thing in Base. |
I'll not spend any more time on it then :) I think it's important to offer a way of telling Coveralls that certain blocks of code do not need to be tested, though. As an aside, is it really of benefit to add CI into Base? It seems to me that this goes against the philosophy of "keep Base simple" - while CI is great for development, once you're in production you don't need it at all. (Or did I misunderstand regarding "a more standardized thing in Base"?) |
I mean a more standardized package metadata format in Base, that can have lots of info, not just this. |
Any plans to incorporate these features? They would be quite useful. |
bump ! would love this |
This package isn't really being actively maintained apart from bug requests, but I'd suggest that if you want it then you should implement it. I still agree with past-me that it should be wrapped into a wider package info file, but maybe I'm wrong about that. |
It doesn't need fresh implementation; this is a PR, and it just needs rebasing (and likely, fixing up). However, up above it was stated that it wouldn't be merged, so that's what needs to be settled first. Personally, I think this is useful functionality. I also confess that I'm struggling to imagine what a "wider package info file" would do/look like. If there aren't concrete suggestions, then perhaps one strategy would be to start the process here and then move out into a separate package once there's a concrete motive for generalization? |
It is unmergeable in its current state. |
I tried to update this PR, but I couldn’t get it working. Should we close this PR in favor of #218? |
This addresses #44 and #53. It allows a per-directory file called '.coverage.yml' that looks like