Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for HTTP to 1, (keep existing compat) #332

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the HTTP package from 0.8, 0.9 to 0.8, 0.9, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM; I looked over the usage of HTTP.jl and no calls should be affected by some of the breaking changes in the 1.0 release.

@quinnj
Copy link
Contributor

quinnj commented Jun 29, 2022

Anyone who can kick off CI/merge here? @DilumAluthge?

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #332 (cc9fa90) into master (5872cf7) will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   90.66%   91.11%   +0.44%     
==========================================
  Files           2        2              
  Lines         225      225              
==========================================
+ Hits          204      205       +1     
+ Misses         21       20       -1     
Impacted Files Coverage Δ
src/coveralls.jl 94.73% <0.00%> (-1.76%) ⬇️
src/codecovio.jl 87.38% <0.00%> (+2.70%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@coveralls
Copy link

coveralls commented Jun 29, 2022

Pull Request Test Coverage Report for Build 2582853176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 91.441%

Files with Coverage Reduction New Missed Lines %
src/codecovio.jl 2 87.96%
src/coveralls.jl 2 94.74%
Totals Coverage Status
Change from base Build 2380675684: 0.5%
Covered Lines: 203
Relevant Lines: 222

💛 - Coveralls

@quinnj
Copy link
Contributor

quinnj commented Jun 29, 2022

@DilumAluthge, CI looks good; merge and tag a new release?

@DilumAluthge DilumAluthge merged commit 26bc182 into master Jun 29, 2022
@DilumAluthge DilumAluthge deleted the compathelper/new_version/2022-06-20-01-51-39-414-02228261896 branch June 29, 2022 19:41
@quinnj
Copy link
Contributor

quinnj commented Jun 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants