Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitlab CI to Coverage #331

Merged
merged 12 commits into from
May 24, 2022
Merged

Add Gitlab CI to Coverage #331

merged 12 commits into from
May 24, 2022

Conversation

theogf
Copy link
Contributor

@theogf theogf commented May 19, 2022

This allows to directly submit the Coverage report to Codecov or Coveralls from a Gitlab action.
This solves #330

@DilumAluthge DilumAluthge requested review from maleadt and vtjnash May 19, 2022 23:05
@coveralls
Copy link

coveralls commented May 19, 2022

Pull Request Test Coverage Report for Build 2378694128

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 91.441%

Files with Coverage Reduction New Missed Lines %
src/codecovio.jl 2 87.96%
src/coveralls.jl 2 94.74%
Totals Coverage Status
Change from base Build 1363428186: 1.06%
Covered Lines: 203
Relevant Lines: 222

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #331 (dfeda28) into master (e22e4fe) will increase coverage by 1.34%.
The diff coverage is 100.00%.

❗ Current head dfeda28 differs from pull request most recent head 0f0258d. Consider uploading reports for the commit 0f0258d to get more accurate results

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   90.09%   91.44%   +1.34%     
==========================================
  Files           2        2              
  Lines         212      222      +10     
==========================================
+ Hits          191      203      +12     
+ Misses         21       19       -2     
Impacted Files Coverage Δ
src/codecovio.jl 87.96% <100.00%> (+3.85%) ⬆️
src/coveralls.jl 94.73% <100.00%> (-1.46%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@maleadt
Copy link
Member

maleadt commented May 20, 2022

There's tests for the other providers, so this PR better needs some as well.

test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@theogf
Copy link
Contributor Author

theogf commented May 23, 2022

Sorry I realized some of the tags were wrong, but somehow I could not change it to draft mode.
Right now push on main works fine but push on a merge request fails.
You can see the results on this test package : https://gitlab.com/theogf/testpackage.jl/-/tree/main

@maleadt maleadt marked this pull request as draft May 23, 2022 09:41
@maleadt
Copy link
Member

maleadt commented May 23, 2022

OK, I've moved it back to draft.

@theogf theogf marked this pull request as ready for review May 23, 2022 09:47
@theogf
Copy link
Contributor Author

theogf commented May 23, 2022

Ok sorry for the whole CI mess! Testing this kind of stuff is really painful! I can now confirm it works for both push on master/main and merge requests (Gitlab name for PRs)

@theogf
Copy link
Contributor Author

theogf commented May 23, 2022

It should now be ready for merging. As said above you can check how it looks on https://gitlab.com/theogf/testpackage.jl/-/tree/main

src/codecovio.jl Outdated Show resolved Hide resolved
@theogf
Copy link
Contributor Author

theogf commented May 23, 2022

Not sure about the bump on the Project.toml, should it be 1.5.0 or 1.4.1 ?

@theogf theogf changed the title Add Gitllab CI to Coverage Add Gitlab CI to Coverage May 24, 2022
@theogf theogf requested a review from maleadt May 24, 2022 12:22
@maleadt
Copy link
Member

maleadt commented May 24, 2022

Since this is a new features, 1.5.0 would be best.

@maleadt maleadt merged commit 5872cf7 into JuliaCI:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants