-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitlab CI to Coverage #331
Conversation
Pull Request Test Coverage Report for Build 2378694128
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 90.09% 91.44% +1.34%
==========================================
Files 2 2
Lines 212 222 +10
==========================================
+ Hits 191 203 +12
+ Misses 21 19 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There's tests for the other providers, so this PR better needs some as well. |
Sorry I realized some of the tags were wrong, but somehow I could not change it to draft mode. |
OK, I've moved it back to draft. |
Ok sorry for the whole CI mess! Testing this kind of stuff is really painful! I can now confirm it works for both push on master/main and merge requests (Gitlab name for PRs) |
It should now be ready for merging. As said above you can check how it looks on https://gitlab.com/theogf/testpackage.jl/-/tree/main |
Not sure about the bump on the Project.toml, should it be 1.5.0 or 1.4.1 ? |
Since this is a new features, 1.5.0 would be best. |
This allows to directly submit the Coverage report to Codecov or Coveralls from a Gitlab action.
This solves #330