Add support for Buildkite. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 90.19% 90.56% +0.36%
==========================================
Files 2 2
Lines 204 212 +8
==========================================
+ Hits 184 192 +8
Misses 20 20
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1306974041
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1306974041
💛 - Coveralls |
|
This seems to be working. In JuliaCI/julia-coverage-buildkite-plugin#3 I've updated the Buildkite plugin to use this branch, and JuliaGPU/CUDA.jl#1185 then specifically uses that version of the plugin. The resulting upload is available at https://app.codecov.io/gh/JuliaGPU/CUDA.jl/compare/1185 (with obviously a lot of red since I didn't run any tests, but there's some lines covered so submission seems to work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only added to Codecov, since as Coveralls doesn't seem to support Buildkite. Not that Codecov supports tokenless uploads from Buildkite, but this at least avoids the need for local git operations to populate the branch, commit, etc.