Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls: fix a deprecated HTTP post call #321

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

DilumAluthge
Copy link
Member

Fixes #308

@DilumAluthge DilumAluthge requested a review from vtjnash June 14, 2021 00:17
@DilumAluthge DilumAluthge changed the title Coveralls: fix a deprectated HTTP post call Coveralls: fix a deprecated HTTP post call Jun 14, 2021
@coveralls
Copy link

coveralls commented Jun 14, 2021

Pull Request Test Coverage Report for Build 934165440

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 90.686%

Files with Coverage Reduction New Missed Lines %
src/codecovio.jl 2 86.87%
src/coveralls.jl 2 94.29%
Totals Coverage Status
Change from base Build 934154514: 0.5%
Covered Lines: 185
Relevant Lines: 204

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #321 (b3394b9) into master (ce273bc) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   90.14%   90.68%   +0.53%     
==========================================
  Files           2        2              
  Lines         203      204       +1     
==========================================
+ Hits          183      185       +2     
+ Misses         20       19       -1     
Impacted Files Coverage Δ
src/coveralls.jl 94.28% <100.00%> (-1.87%) ⬇️
src/codecovio.jl 86.86% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce273bc...b3394b9. Read the comment docs.

@DilumAluthge DilumAluthge merged commit fc62bc5 into master Jun 14, 2021
@DilumAluthge DilumAluthge deleted the dpa/fix-deprecated-post-call branch June 14, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix deprecated HTTP post call
3 participants