Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation inside modules #319

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Fix indentation inside modules #319

merged 1 commit into from
Jun 13, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 13, 2021

Most Julia packages follow the convention that you don't increase an indentation level inside a module.

This PR fixes the code in this package to follow that convention.

There are no changes other than fixing the indentation and whitespace.

@DilumAluthge DilumAluthge requested a review from vtjnash June 13, 2021 23:34
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #319 (7e69ff8) into master (996d94c) will increase coverage by 0.49%.
The diff coverage is 90.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   90.14%   90.64%   +0.49%     
==========================================
  Files           2        2              
  Lines         203      203              
==========================================
+ Hits          183      184       +1     
+ Misses         20       19       -1     
Impacted Files Coverage Δ
src/codecovio.jl 86.86% <86.86%> (+3.03%) ⬆️
src/coveralls.jl 94.23% <94.23%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996d94c...7e69ff8. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 13, 2021

Pull Request Test Coverage Report for Build 934114613

  • 184 of 203 (90.64%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 90.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 98 104 94.23%
src/codecovio.jl 86 99 86.87%
Totals Coverage Status
Change from base Build 934106591: 0.5%
Covered Lines: 184
Relevant Lines: 203

💛 - Coveralls

@DilumAluthge DilumAluthge marked this pull request as ready for review June 13, 2021 23:42
@DilumAluthge DilumAluthge changed the title [WIP] Fix indentation inside modules Fix indentation inside modules Jun 13, 2021
@DilumAluthge DilumAluthge merged commit 223e5c6 into master Jun 13, 2021
@DilumAluthge DilumAluthge deleted the dpa/indentation branch June 13, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants