Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codecov upload API to v4 #304

Closed
wants to merge 2 commits into from
Closed

Update Codecov upload API to v4 #304

wants to merge 2 commits into from

Conversation

ararslan
Copy link
Member

@ararslan
Copy link
Member Author

RIP, looks like there's no CI here anymore. Guess we'll need to set up GHA.

src/codecovio.jl Outdated Show resolved Hide resolved
@vtjnash
Copy link
Member

vtjnash commented May 10, 2021

Can you rebase and re-enable CI submission on https://github.com/JuliaCI/Coverage.jl/blob/master/etc/travis-coverage.jl#L4

@ararslan
Copy link
Member Author

I've rebased. I don't know what you mean about reenabling submission but feel free to push to this branch.

@vtjnash
Copy link
Member

vtjnash commented May 10, 2021

You'll need to remove the conditional on that line. Looks like you might need to disable the blackhole server that we use for testing also (or provide a way to specify the API via an environment variable, and use v2 there?)

@DilumAluthge DilumAluthge requested a review from vtjnash June 8, 2021 22:05
@DilumAluthge DilumAluthge force-pushed the aa/codecov-v4 branch 2 times, most recently from 55d4c5f to 7f2f387 Compare June 9, 2021 04:56
@DilumAluthge
Copy link
Member

DilumAluthge commented Jun 9, 2021

I have rebased, and I have enabled submission (i.e. we've removed all conditionals from https://github.com/JuliaCI/Coverage.jl/blob/master/etc/travis-coverage.jl)

However, it looks like CI is failing on the PR.

(For reference, CI is passing on master.)

@DilumAluthge DilumAluthge requested review from vtjnash and removed request for vtjnash June 9, 2021 04:58
@vtjnash
Copy link
Member

vtjnash commented Jun 9, 2021

Yeah, it fails on the blackhole server we used for testing.

@DilumAluthge
Copy link
Member

@ararslan @vtjnash Based on #316, it seems like the only issue with this PR is the blackhole server bug. How do y'all want to proceed?

@ararslan
Copy link
Member Author

¯\_(ツ)_/¯

@DilumAluthge
Copy link
Member

@vtjnash Can you explain the purpose of the black-hole server?

@vtjnash
Copy link
Member

vtjnash commented Jun 13, 2021

It avoided cluttering the list of log files with duplicate entries–no practical benefit to it

@DilumAluthge
Copy link
Member

Alright, I think I have a way to fix it. Basically:

  1. If we are not using the "black hole" server, we upload to S3
  2. If we are using the "black hole" server, we do not upload to S3

See PR #318.

For the diff between this PR and PR #318, see here: aa/codecov-v4...dpa/codecov-v4

ararslan and others added 2 commits June 13, 2021 17:09
DilumAluthge added a commit that referenced this pull request Jun 13, 2021
Update Codecov upload API to v4 (replacement for #304)
@DilumAluthge DilumAluthge deleted the aa/codecov-v4 branch June 13, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants