-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Codecov upload API to v4 #304
Conversation
RIP, looks like there's no CI here anymore. Guess we'll need to set up GHA. |
Can you rebase and re-enable CI submission on https://github.com/JuliaCI/Coverage.jl/blob/master/etc/travis-coverage.jl#L4 |
I've rebased. I don't know what you mean about reenabling submission but feel free to push to this branch. |
You'll need to remove the conditional on that line. Looks like you might need to disable the blackhole server that we use for testing also (or provide a way to specify the API via an environment variable, and use v2 there?) |
55d4c5f
to
7f2f387
Compare
I have rebased, and I have enabled submission (i.e. we've removed all conditionals from https://github.com/JuliaCI/Coverage.jl/blob/master/etc/travis-coverage.jl) However, it looks like CI is failing on the PR. (For reference, CI is passing on |
Yeah, it fails on the blackhole server we used for testing. |
7f2f387
to
d973431
Compare
¯\_(ツ)_/¯ |
@vtjnash Can you explain the purpose of the black-hole server? |
It avoided cluttering the list of log files with duplicate entries–no practical benefit to it |
Alright, I think I have a way to fix it. Basically:
See PR #318. For the diff between this PR and PR #318, see here: aa/codecov-v4...dpa/codecov-v4 |
thanks bud Co-authored-by: Jameson Nash <[email protected]>
d973431
to
9c2e092
Compare
Update Codecov upload API to v4 (replacement for #304)
Guessing based on https://docs.codecov.io/reference#upload.