Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations and depwarns #295

Merged
merged 1 commit into from
Nov 17, 2020
Merged

remove deprecations and depwarns #295

merged 1 commit into from
Nov 17, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 17, 2020

Probably been long enough.

Probably been long enough.
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #295 (0212b76) into master (36fc28a) will increase coverage by 3.88%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   81.90%   85.79%   +3.88%     
==========================================
  Files           3        3              
  Lines         199      183      -16     
==========================================
- Hits          163      157       -6     
+ Misses         36       26      -10     
Impacted Files Coverage Δ
src/coveralls.jl 91.83% <80.00%> (+5.04%) ⬆️
src/codecovio.jl 78.57% <100.00%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fc28a...0212b76. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 17, 2020

Pull Request Test Coverage Report for Build 936

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 86.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 932: 3.2%
Covered Lines: 123
Relevant Lines: 143

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 936

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 86.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 932: 3.2%
Covered Lines: 123
Relevant Lines: 143

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 936

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 86.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 932: 3.2%
Covered Lines: 123
Relevant Lines: 143

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 936

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 86.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 932: 3.2%
Covered Lines: 123
Relevant Lines: 143

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 936

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 86.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coveralls.jl 2 3 66.67%
Totals Coverage Status
Change from base Build 932: 3.2%
Covered Lines: 123
Relevant Lines: 143

💛 - Coveralls

@fingolfin fingolfin merged commit 5c86b0d into master Nov 17, 2020
@fingolfin fingolfin deleted the jn/deprecate branch November 17, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants