Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: fix error reporting printing #293

Merged
merged 1 commit into from
Nov 17, 2020
Merged

codecov: fix error reporting printing #293

merged 1 commit into from
Nov 17, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 17, 2020

Previously, this would print an html page, now it will print the error message

Fixes #276

Previously, this would print an html page, now it will print the error message

Fixes #276
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #293 (319daf5) into master (36fc28a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files           3        3           
  Lines         199      199           
=======================================
  Hits          163      163           
  Misses         36       36           
Impacted Files Coverage Δ
src/codecovio.jl 76.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fc28a...319daf5. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 17, 2020

Pull Request Test Coverage Report for Build 934

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%

Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 934

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%

Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 934

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%

Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 934

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%

Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 934

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.803%

Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 130
Relevant Lines: 157

💛 - Coveralls

@fingolfin
Copy link
Member

I have no idea what this does, but I trust that @vtjnash knows what he does (in this case, at least 😝 )

@fingolfin fingolfin merged commit 1b546ae into master Nov 17, 2020
@fingolfin fingolfin deleted the jn/276 branch November 18, 2020 07:53
@vtjnash vtjnash changed the title Coveralls: fix error reporting printing codecov: fix error reporting printing Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error uploading coverage stats
4 participants