-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GitHub Actions #233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 90.53% 90.11% -0.42%
==========================================
Files 6 6
Lines 338 344 +6
==========================================
+ Hits 306 310 +4
- Misses 32 34 +2
Continue to review full report at Codecov.
|
Ready for review. Might be a good idea to squash things before a merge, there are some false starts in the commit history. |
Bump. |
Bump. @davidanthoff What's the status of this PR? |
From my end it is ready for review and merging. |
Do you know who the current maintainers of Coverage.jl are? We could ping them on GitHub and/or Slack. |
service = "custom", | ||
commit = ENV["GITHUB_SHA"], | ||
slug = ENV["GITHUB_REPOSITORY"], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add branch = GITHUB_REF?
and maybe pr?? = GITHUB_EVENT_NAME
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had the branch=
story in there before, and for some reason removed it, I think maybe it didn't work? I can't remember...
I don't have time right now to make more changes and test them, so I would suggest we merge the current version (because that certainly works), and then if someone else has more time to add more info and test out whether that works we can do it in a follow up PR?
Great! Can we also tag a new release? |
Fixes #232.