Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Actions #233

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Conversation

davidanthoff
Copy link
Contributor

Fixes #232.

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #233 into master will decrease coverage by 0.41%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   90.53%   90.11%   -0.42%     
==========================================
  Files           6        6              
  Lines         338      344       +6     
==========================================
+ Hits          306      310       +4     
- Misses         32       34       +2
Impacted Files Coverage Δ
src/codecovio.jl 86.15% <50%> (-1.15%) ⬇️
src/coveralls.jl 79.1% <50%> (-0.9%) ⬇️
src/lcov.jl 96.07% <0%> (-1.93%) ⬇️
src/Coverage.jl 98.13% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1883f...dec5ee0. Read the comment docs.

@davidanthoff davidanthoff marked this pull request as ready for review September 16, 2019 01:02
@davidanthoff
Copy link
Contributor Author

Ready for review. Might be a good idea to squash things before a merge, there are some false starts in the commit history.

@DilumAluthge
Copy link
Member

Bump.

@DilumAluthge
Copy link
Member

Bump. @davidanthoff What's the status of this PR?

@davidanthoff
Copy link
Contributor Author

From my end it is ready for review and merging.

@DilumAluthge
Copy link
Member

Do you know who the current maintainers of Coverage.jl are? We could ping them on GitHub and/or Slack.

service = "custom",
commit = ENV["GITHUB_SHA"],
slug = ENV["GITHUB_REPOSITORY"],
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add branch = GITHUB_REF? and maybe pr?? = GITHUB_EVENT_NAME?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had the branch= story in there before, and for some reason removed it, I think maybe it didn't work? I can't remember...

I don't have time right now to make more changes and test them, so I would suggest we merge the current version (because that certainly works), and then if someone else has more time to add more info and test out whether that works we can do it in a follow up PR?

@vtjnash vtjnash merged commit 6f8f7fd into JuliaCI:master Sep 23, 2019
@davidanthoff davidanthoff deleted the githubactions branch September 23, 2019 18:32
@davidanthoff
Copy link
Contributor Author

Great! Can we also tag a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No CI support for Github Actions
4 participants