Remove verbose flag, change some @info to @debug #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 93.69% 91.36% -2.33%
==========================================
Files 6 6
Lines 333 336 +3
==========================================
- Hits 312 307 -5
- Misses 21 29 +8
Continue to review full report at Codecov.
|
sebasguts
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
This would be very helpful to avoid travis logs like this one: https://travis-ci.com/oscar-system/GAPJulia/jobs/183832731
ararslan
requested changes
Mar 11, 2019
fingolfin
force-pushed
the
mh/logging
branch
2 times, most recently
from
a45e578 to
779ba5f
Compare
ararslan
approved these changes
Mar 15, 2019
There is no point in Coverage.LCOV.readfolder and Coverage.clean_folder reporting every file they did *not* process; this just clogs up build logs, and almost always is useless; so change this from @info to @debug. Also, by default user won't want to know the JSON replies of Codecov and Coveralls, nor the exact URL we used to submit to Codecov, so change those from @info to @debug as well. On the other hand, knowing which files actually are being processed *is* useful, so add an @info message for that (I recently had an exception thrown in that code and had a hard time figuring out which file was being proceed, so this will help). Finally, deprecate the `verbose` keyword flag; instead, users should adjust the logging level to suppress or show various messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in Coverage.LCOV.readfolder and Coverage.clean_folder
reporting every file they did not process; this just clogs up build logs,
and almost always is useless; so change this from @info to @debug.
Also, by default user won't want to know the JSON replies of Codecov and
Coveralls, nor the exact URL we used to submit to Codecov, so change those
from @info to @debug as well.
On the other hand, knowing which files actually are being processed is
useful, so add an @info message for that (I recently had an exception thrown
in that code and had a hard time figuring out which file was being proceed, so
this will help).
Finally, get rid of the
verbosekeyword flag; instead, users can adjust thelogging level to suppress or show various messages.