Coveralls: assert that github_pr is either a string or an integer, …

…and don't rely on integers being "non-empty" (#317)
JuliaCI · Jun 10, 2021 · b79485e · b79485e · DilumAluthge · Jun 10, 2021
1 parent aa01a30
commit b79485e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Coverage"
 uuid = "a2441757-f6aa-5fb2-8edb-039e3f45d037"
 authors = ["Iain Dunning <[email protected]>", "contributors"]
-version = "1.2.1"
+version = "1.2.2"
 
 [deps]
 CoverageTools = "c36e975a-824b-4404-a568-ef97ca766997"

diff --git a/src/coveralls.jl b/src/coveralls.jl
@@ -102,7 +102,8 @@ module Coveralls
             event_path = open(JSON.Parser.parse, ENV["GITHUB_EVENT_PATH"])
             github_pr_info = get(event_path, "pull_request", Dict())
             github_pr = get(github_pr_info, "number", "")
-            isempty(github_pr) || (data["service_pull_request"] = strip(string(github_pr)))
+            github_pr::Union{AbstractString, Integer}
+            ((github_pr isa Integer) || (!isempty(github_pr))) && (data["service_pull_request"] = strip(string(github_pr)))
         else
             data["git"] = parse_git_info(git_info)
         end