Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated array constructor #90

Merged
merged 2 commits into from
Dec 3, 2017
Merged

fix deprecated array constructor #90

merged 2 commits into from
Dec 3, 2017

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre
Copy link
Member Author

needs JuliaLang/METADATA.jl#12295

@fredrikekre fredrikekre closed this Dec 1, 2017
@fredrikekre fredrikekre reopened this Dec 1, 2017
@ararslan
Copy link
Member

ararslan commented Dec 2, 2017

For whatever reason, I made the module name IterativeEigenSolvers (note the uppercase S), so the using will need to be adjusted.

@fredrikekre
Copy link
Member Author

Ah, thanks! I got it right in the commit message at least :)

@fredrikekre
Copy link
Member Author

Fixed. Btw, IterativeEigenSolvers is only needed for this:

BenchmarkTools.jl/test/ExecutionTests.jl

Line 27 in c684b3e

groups["special"]["kwargs"] = @benchmarkable svds(rand(2, 2), nsv = 1)
so could perhaps be worth replacing that kwarg test with something else and not depend on IterativeEigenSolvers

@ararslan ararslan merged commit 2e27add into JuliaCI:master Dec 3, 2017
@fredrikekre fredrikekre deleted the fe/uninitialized branch December 4, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @ararslan