Support manual range for hist display #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to manually set the range of the histogram during display via an `IOContext`. The main use-case is for comparing multiple `@benchmark` runs using a common axis for the histogram.
|
I'm very happy to see this PR, thanks Tim! I've been wanting to make the histogram customisable like this for some time now, but have just been too busy. To me, the way this has been implemented looks pretty reasonable. A |
vchuravy
approved these changes
Sep 16, 2021
|
This is great! |
This was referenced Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to manually set the range of the histogram during
display via an
IOContext. The main use-case is for comparingmultiple
@benchmarkruns using a common axis for thehistogram.
Here's an example from the manual:
CC @tecosaur