add benchmarks for accumulate and cumsum #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the error is: @ararslan do we need to make changes here to get this working on 0.7? |
ararslan
reviewed
Mar 27, 2018
src/array/ArrayBenchmarks.jl
Outdated
| g["cumsum!", "Int"] = @benchmarkable cumsum!($resaint, $aint) | ||
|
|
||
| mfloat = samerand(10^3,10^3) | ||
| g["cumsum", "Float64", "dim1"] = @benchmarkable cumsum($mfloat, dims=1) |
There was a problem hiding this comment.
I think this will need to be Compat.cumsum (similarly with the others) for the dims keyword argument.
|
I have absolutely no idea what that error is about. |
|
Just FYI I won't be able to retune benchmarks and rerun Nanosoldier on your PR until MIT is finished with their on-site stuff and the machines are turned back on. |
ararslan
approved these changes
Mar 27, 2018
jw3126
reviewed
Mar 29, 2018
| g["accumulate!", "Int"] = @benchmarkable accumulate!(+, $resaint, $aint) | ||
|
|
||
| g["cumsum!", "Float64"] = @benchmarkable cumsum!($resafloat, $afloat) | ||
| g["cumsum!", "Int"] = @benchmarkable cumsum!($resaint, $aint) |
There was a problem hiding this comment.
There are overlapping benchmarks here, maybe they should be removed.
Keno
pushed a commit
that referenced
this pull request
Feb 4, 2022
force strings early in definition, but allow some other JSON-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing JuliaLang/julia#25766