Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Compat" to "4" #94

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Compat package from 2, 3 to 2, 3, 4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rob-luke rob-luke force-pushed the compathelper/new_version/2022-05-17-00-53-07-172-3649983242 branch from facb233 to b6387c9 Compare May 17, 2022 00:53
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #94 (8fd2b8c) into master (faec5bb) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   76.59%   76.20%   -0.39%     
==========================================
  Files           6        6              
  Lines         440      437       -3     
==========================================
- Hits          337      333       -4     
- Misses        103      104       +1     
Impacted Files Coverage Δ
src/SampleStream.jl 91.62% <0.00%> (-0.54%) ⬇️
src/SampleBuf.jl 71.52% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faec5bb...8fd2b8c. Read the comment docs.

@jpsamaroo
Copy link

Bump, being limited to Compat 3 is breaking precompile for me on 1.9.

@ssfrr ssfrr merged commit 51ea6bc into master Oct 2, 2023
@ssfrr ssfrr mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants