-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downgrade of packages #65
Conversation
I think this is correct syntax but it's not tested. I was adding LibSndFile but this package seems to be the cause (or Compat). I think their reason for version 3 is just to simplify code (issue 651), dropping support for Julia 0.7, and you would keep it if you allow Compat 2.x.
FYI: I can confirm this fixed the downgrade (i.e. until you tag):
and I could at least do my test there (but it didn't fix the speed-problem there, or is the cause maybe in this package?): |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 71.32% 73.68% +2.36%
==========================================
Files 6 6
Lines 401 437 +36
==========================================
+ Hits 286 322 +36
Misses 115 115
Continue to review full report at Codecov.
|
Hi, is there any news for this? For example if you're using Flux, adding this package downgrades many others: (test_pkg) pkg> add SampledSignals
Resolving package versions...
Installed ChainRules ─────── v0.6.5
Installed Zygote ─────────── v0.5.1
Installed SpecialFunctions ─ v1.1.0
Installed CUDA ───────────── v2.2.1
Installed ChainRulesCore ─── v0.8.1
Updating `~/Julia/test_pkg/Project.toml`
[587475ba] ↓ Flux v0.11.6 ⇒ v0.11.3
[bd7594eb] + SampledSignals v2.1.0
Updating `~/Julia/test_pkg/Manifest.toml`
[79e6a3ab] ↓ Adapt v3.2.0 ⇒ v2.4.0
[4c555306] + ArrayLayouts v0.3.8
[052768ef] ↓ CUDA v2.4.1 ⇒ v2.2.1
[082447d4] ↓ ChainRules v0.7.50 ⇒ v0.6.5
[d360d2e6] ↓ ChainRulesCore v0.9.28 ⇒ v0.8.1
[34da2185] ↓ Compat v3.25.0 ⇒ v2.2.1
.... |
Right, it should be trivial to merge (and I'm pretty sure ok), but I do not have privileges to do that, so until done use my PR as mentioned above with:
|
@ssfrr are you here? is this package abandoned, or can you merge things in? If it is abandoned, can you perhaps consider moving it to some other org, e.g. JuliaDSP or JuliaMusic? EDIT: Ah, lol, this package is already part of an org. I guess we need to find admins in JuliaAudio. |
I'm willing to be an admin for the JuliaAudio org. I have a long Julia history, extensive dev experience, and just started a 3 year postdoc in audio signal processing, so I should be around for a bit. |
that's great to hear, but you are still faced with the difficulty of actually finding an admin of JuliaAudio to make you one :P |
I've been watching these packages for many years and @ssfrr still appears. Not every day, I'm sure he will respond when he has time. We all have lives outside too. |
merged and just made @rob-luke a JuliaAudio admin. I've had very little time for julia work lately - thanks for the offers of assistance! |
I think this is correct syntax but it's not tested.
I was adding LibSndFile but this package seems to be the cause (or Compat). I think their reason for version 3 is just to simplify code (issue 651), dropping support for Julia 0.7, and you would keep it if you allow Compat 2.x.
If this works, please tag a release.