Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downgrade of packages #65

Merged
merged 1 commit into from
May 8, 2021
Merged

Conversation

PallHaraldsson
Copy link
Contributor

I think this is correct syntax but it's not tested.

I was adding LibSndFile but this package seems to be the cause (or Compat). I think their reason for version 3 is just to simplify code (issue 651), dropping support for Julia 0.7, and you would keep it if you allow Compat 2.x.

If this works, please tag a release.

I think this is correct syntax but it's not tested.

I was adding LibSndFile but this package seems to be the cause (or Compat). I think their reason for version 3 is just to simplify code (issue 651), dropping support for Julia 0.7, and you would keep it if you allow Compat 2.x.
@PallHaraldsson
Copy link
Contributor Author

FYI: I can confirm this fixed the downgrade (i.e. until you tag):

(@v1.7) pkg> add SampledSignals#6a9c6a5

and I could at least do my test there (but it didn't fix the speed-problem there, or is the cause maybe in this package?):
JuliaAudio/LibSndFile.jl#37

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #65 (6a9c6a5) into master (700ab7a) will increase coverage by 2.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   71.32%   73.68%   +2.36%     
==========================================
  Files           6        6              
  Lines         401      437      +36     
==========================================
+ Hits          286      322      +36     
  Misses        115      115              
Impacted Files Coverage Δ
src/SignalGen/SinSource.jl 100.00% <0.00%> (ø)
src/SampleStream.jl 91.62% <0.00%> (+0.46%) ⬆️
src/SampleBuf.jl 71.52% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700ab7a...6a9c6a5. Read the comment docs.

@nantonel
Copy link

Hi, is there any news for this?

For example if you're using Flux, adding this package downgrades many others:

(test_pkg) pkg> add SampledSignals
  Resolving package versions...
  Installed ChainRules ─────── v0.6.5
  Installed Zygote ─────────── v0.5.1
  Installed SpecialFunctions ─ v1.1.0
  Installed CUDA ───────────── v2.2.1
  Installed ChainRulesCore ─── v0.8.1
Updating `~/Julia/test_pkg/Project.toml`
  [587475ba]  Flux v0.11.6  v0.11.3
  [bd7594eb] + SampledSignals v2.1.0
Updating `~/Julia/test_pkg/Manifest.toml`
  [79e6a3ab]  Adapt v3.2.0  v2.4.0
  [4c555306] + ArrayLayouts v0.3.8
  [052768ef]  CUDA v2.4.1  v2.2.1
  [082447d4]  ChainRules v0.7.50  v0.6.5
  [d360d2e6]  ChainRulesCore v0.9.28  v0.8.1
  [34da2185]  Compat v3.25.0  v2.2.1
....

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Feb 12, 2021

Right, it should be trivial to merge (and I'm pretty sure ok), but I do not have privileges to do that, so until done use my PR as mentioned above with:

(@v1.7) pkg> add SampledSignals#6a9c6a5

@Datseris
Copy link

Datseris commented Apr 20, 2021

@ssfrr are you here? is this package abandoned, or can you merge things in? If it is abandoned, can you perhaps consider moving it to some other org, e.g. JuliaDSP or JuliaMusic?

EDIT: Ah, lol, this package is already part of an org. I guess we need to find admins in JuliaAudio.

@rob-luke
Copy link
Member

I guess we need to find admins in JuliaAudio.

I'm willing to be an admin for the JuliaAudio org. I have a long Julia history, extensive dev experience, and just started a 3 year postdoc in audio signal processing, so I should be around for a bit.

@Datseris
Copy link

that's great to hear, but you are still faced with the difficulty of actually finding an admin of JuliaAudio to make you one :P

@rob-luke
Copy link
Member

I've been watching these packages for many years and @ssfrr still appears. Not every day, I'm sure he will respond when he has time. We all have lives outside too.

@ssfrr ssfrr merged commit 69b9f11 into JuliaAudio:master May 8, 2021
@ssfrr
Copy link
Collaborator

ssfrr commented May 8, 2021

merged and just made @rob-luke a JuliaAudio admin. I've had very little time for julia work lately - thanks for the offers of assistance!

@PallHaraldsson PallHaraldsson deleted the patch-1 branch May 10, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants