Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing with intervals has broken #52

Closed
ssfrr opened this issue Nov 19, 2019 · 1 comment
Closed

indexing with intervals has broken #52

ssfrr opened this issue Nov 19, 2019 · 1 comment

Comments

@ssfrr
Copy link
Collaborator

ssfrr commented Nov 19, 2019

Not sure when this broke, but indexing with intervals seems to be having trouble.

using SampledSignals
using IntervalSets

b = SampleBuf(randn(10), 48000)
b[1..3]

gives ERROR: DimensionError: 1 Hz s and s are not dimensionally compatible.. The problem seems to be in the code that converts to raw indexes, where it's introducing a frame unit and causing problems. Related to #35 but that passed CI so I'm not sure what changed.

ssfrr added a commit that referenced this issue Nov 19, 2019
@ssfrr
Copy link
Collaborator Author

ssfrr commented Nov 19, 2019

I think the issue is that Quantity is a more specific type than DimensionlessQuantity. I'm guessing that wasn't the case when #35 was merged, but changed in Unitful.jl at some point. Should be fixed by #53

@ssfrr ssfrr closed this as completed in 169d9f1 Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant