Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to GitHub Actions #27

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Move CI to GitHub Actions #27

merged 1 commit into from
Nov 29, 2021

Conversation

giordano
Copy link
Member

@giordano giordano commented Nov 29, 2021

Close #26

@giordano giordano merged commit ae685f4 into JuliaAstro:master Nov 29, 2021
@giordano giordano deleted the mg/ci branch November 29, 2021 22:31
Copy link
Member

@mileslucas mileslucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops too late

Comment on lines +3 to +8
on:
push:
branches: "master"
tags: ["*"]
pull_request:
release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
push:
branches: "master"
tags: ["*"]
pull_request:
release:
on:
push:
branches: ["master"]
tags: ["*"]
pull_request:
branches: ["master"]

IIRC releases automatically create tags, so there's no need to have both in the CI.

tags: ["*"]
pull_request:
release:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
concurrency:
# Skip intermediate builds: always.
# Cancel intermediate builds: only if it is a pull request build.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

copied from the PkgTemplates CI

continue-on-error: true
- uses: julia-actions/[email protected]
continue-on-error: true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also been adding a job to CI for aqua tests to catch things like missing compat, etc. if you want to add it! Here's a copy from another JuliaAstro repo

Suggested change
aqua:
name: Aqua tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
with:
version: '1'
- uses: julia-actions/julia-buildpkg@v1
- run: julia -e 'using Pkg; Pkg.add("Aqua")'
- run: julia --project=@. -e 'using Aqua, UnitfulAstro; Aqua.test_all(UnitfulAstro, ambiguities=false)'

@giordano
Copy link
Member Author

Mind doing a PR with the suggested changes? 😁

@mileslucas
Copy link
Member

I'll do that tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants