-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI to GitHub Actions #27
Conversation
cd3d9ec
to
4cd3007
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops too late
on: | ||
push: | ||
branches: "master" | ||
tags: ["*"] | ||
pull_request: | ||
release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on: | |
push: | |
branches: "master" | |
tags: ["*"] | |
pull_request: | |
release: | |
on: | |
push: | |
branches: ["master"] | |
tags: ["*"] | |
pull_request: | |
branches: ["master"] |
IIRC releases automatically create tags, so there's no need to have both in the CI.
tags: ["*"] | ||
pull_request: | ||
release: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concurrency: | |
# Skip intermediate builds: always. | |
# Cancel intermediate builds: only if it is a pull request build. | |
group: ${{ github.workflow }}-${{ github.ref }} | |
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }} | |
copied from the PkgTemplates CI
continue-on-error: true | ||
- uses: julia-actions/[email protected] | ||
continue-on-error: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also been adding a job to CI for aqua tests to catch things like missing compat, etc. if you want to add it! Here's a copy from another JuliaAstro repo
aqua: | |
name: Aqua tests | |
runs-on: ubuntu-latest | |
steps: | |
- uses: actions/checkout@v2 | |
- uses: julia-actions/setup-julia@v1 | |
with: | |
version: '1' | |
- uses: julia-actions/julia-buildpkg@v1 | |
- run: julia -e 'using Pkg; Pkg.add("Aqua")' | |
- run: julia --project=@. -e 'using Aqua, UnitfulAstro; Aqua.test_all(UnitfulAstro, ambiguities=false)' |
Mind doing a PR with the suggested changes? 😁 |
I'll do that tomorrow! |
Close #26