Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extrema #338

Merged
merged 1 commit into from
Nov 15, 2017
Merged

fix extrema #338

merged 1 commit into from
Nov 15, 2017

Conversation

SimonDanisch
Copy link
Member

I could have sworn that I already fixed this.
I'm not sure why this only turns up in a couple of cases - I can't even construct a test case for this.
But for some Arrays, mapreduce isn't able to correctly take the first element of the array as the reduce variable.
I remember debugging this already and it lead me to quite a bit of dark magic in the code of mapreduce.

@codecov-io
Copy link

Codecov Report

Merging #338 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   93.36%   93.36%   +<.01%     
==========================================
  Files          37       37              
  Lines        2711     2712       +1     
==========================================
+ Hits         2531     2532       +1     
  Misses        180      180
Impacted Files Coverage Δ
src/FixedSizeArrays.jl 41.66% <83.33%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ec063...ae51586. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 93.363% when pulling ae51586 on sd/extrema into 11ec063 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants