Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChainRules Overloads to StaticArrays #1224

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Dec 9, 2023

These rules were a part of SciMLSensitivity https://github.com/SciML/SciMLSensitivity.jl/blob/f1aa09244e45598874e1a14a008356a2b2b241a1/src/staticarrays.jl#L23

I will add some tests. But any objections to moving them here?

cc @ChrisRackauckas

@avik-pal
Copy link
Contributor Author

avik-pal commented Dec 9, 2023

It seems there is an older PR #1068

I have moved the dependency into a weakdep and added more minimal tests based on the discussion there. Let me know what else needs to be done.

@avik-pal avik-pal force-pushed the ap/chainrules branch 2 times, most recently from 23e1e1e to 3ebb07c Compare December 10, 2023 01:51
@ChrisRackauckas
Copy link
Member

Given the discussion in #1068 and JuliaDiff/ChainRules.jl#761, this is the proper place for it to live. The only issue people brought up in #1068 was the dependency size, which is addressed by this PR using package extensions, so it looks good to go.

@ChrisRackauckas ChrisRackauckas merged commit 91f4857 into JuliaArrays:master Dec 14, 2023
22 of 29 checks passed
@avik-pal avik-pal deleted the ap/chainrules branch December 14, 2023 16:14
@oxinabox
Copy link
Member

If someone wants to add this to our Downstream tests in ChainRulesCore CI we can make sure not to accidentally break it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants