Comment on why we use vcat

JuliaArrays · Feb 14, 2020 · 3db20ef · 3db20ef
1 parent b665233
commit 3db20ef
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/mapreduce.jl b/src/mapreduce.jl
@@ -309,6 +309,8 @@ _valof(::Val{D}) where D = D
         (init = (similar_type(a, Union{}, Size(0))(), init),),
     ) do (ys, acc), x
         y = rf(acc, x)
+        # Not using `push(ys, y)` here since we need to widen element type as
+        # we iterate.
         (vcat(ys, SA[y]), y)
     end
     dims === (:) && return first(results)