-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive indexing of concatenated arrays #133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 87.13% 87.03% -0.11%
==========================================
Files 12 12
Lines 1360 1357 -3
==========================================
- Hits 1185 1181 -4
- Misses 175 176 +1
Continue to review full report at Codecov.
|
Looks like just one line is missing in coverage, are you able to cover this? (Sometimes its just a bug in codecov and I can merge as is in that case.) |
Sorry, I had left a function that in the end I didn't use. Should be good now. |
If bump the patch version (to v0.17.7) I can merge and tag right away |
Actually I'll just do the tag now |
This is an attempt to fix the performance issues discussed in #132. These are type instability issues when indexing heterogeneous concatenated arrays with
getindex
andsetindex!
.In this PR,
getindex
andsetindex!
are reimplemented for theVcat{1}
,Vcat{2}
andHcat
lazy concatenation types.Here is a small benchmark for comparison, on Julia 1.5.1:
On LazyArrays master:
With this PR: