Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize axes for InfRanges #141

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Specialize axes for InfRanges #141

merged 2 commits into from
Aug 28, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 27, 2023

Since the fallback method that used to use oneto is now removed on v1.11, we need to specialize axes for InfRanges. In any case, since oneto is internal to Base, it's best to not rely on it unless absolutely necessary.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #141 (bc8515c) into master (8fe1160) will decrease coverage by 2.08%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   85.89%   83.81%   -2.08%     
==========================================
  Files           6        6              
  Lines         730      692      -38     
==========================================
- Hits          627      580      -47     
- Misses        103      112       +9     
Files Changed Coverage Δ
src/infrange.jl 83.88% <100.00%> (-3.62%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub jishnub requested a review from dlfivefifty August 28, 2023 05:02
@dlfivefifty dlfivefifty merged commit 87c6d89 into JuliaArrays:master Aug 28, 2023
@jishnub jishnub deleted the axes branch August 28, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants