Preserve infinite step ranges in views (#203)

* Preserve infinite step ranges in views * Remove unnecessary method
JuliaArrays · Dec 2, 2024 · 66441ec · 66441ec
1 parent a9b8a1b
commit 66441ec
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/infrange.jl b/src/infrange.jl
@@ -284,6 +284,10 @@ function getindex(Ac::AdjOrTrans{<:Any,<:InfRanges}, k::Integer, j::InfAxes)
     parent(Ac)[j]
 end
 
+# views may preserve InfStepRanges
+Base.@propagate_inbounds Base.view(r::InfStepRange, i::AbstractUnitRange{<:Integer}) = r[i]
+Base.@propagate_inbounds Base.view(r::InfStepRange, i::InfStepRange{<:Integer}) = r[i]
+Base.@propagate_inbounds Base.view(r::InfStepRange, i::StepRange{<:Integer}) = r[i]
 
 show(io::IO, r::InfUnitRange) = print(io, repr(first(r)), ':', repr(∞))
 show(io::IO, r::OneToInf{Int}) = print(io, "OneToInf()")

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -391,6 +391,16 @@ end
         @test (1:-1:-∞)[1:∞] == 1:-1:-∞
     end
 
+    @testset "view(InfStepRange, inf-range)" begin
+        r = 2:5:∞
+        @test view(r, axes(r,1)) === r
+        @test view(r, 1:1:∞) === r
+        @test view(r, 2:2:∞) === 7:10:∞
+        r2 = 2:5:10_000 # arbitrary high upper cutoff
+        @test view(r, 4:10) == view(r2, 4:10)
+        @test view(r, 4:7:50) == view(r2, 4:7:50)
+    end
+
     @testset "OneToInf" begin
         r = OneToInf()
         @test !isempty(r)
@@ -1265,4 +1275,4 @@ end
 include("test_infconv.jl")
 include("test_infblock.jl")
 include("test_infbanded.jl")
-include("test_infblockbanded.jl")
+include("test_infblockbanded.jl")