Support maximum(Block(OneTo(+∞)) (#211)

* maximum * mention pr
JuliaArrays · Dec 9, 2024 · 13184d6 · 13184d6 · dlfivefifty · Dec 9, 2024
1 parent 854d430
commit 13184d6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "InfiniteArrays"
 uuid = "4858937d-0d70-526a-a4dd-2d5cb5dd786c"
-version = "0.15.1"
+version = "0.15.2"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

diff --git a/ext/InfiniteArraysBlockArraysExt.jl b/ext/InfiniteArraysBlockArraysExt.jl
@@ -2,10 +2,10 @@ module InfiniteArraysBlockArraysExt
 using InfiniteArrays, BlockArrays
 using InfiniteArrays.ArrayLayouts, InfiniteArrays.LazyArrays, InfiniteArrays.LinearAlgebra
 
-import Base: length, size, axes, BroadcastStyle, copy, +, -
+import Base: length, size, axes, BroadcastStyle, copy, +, -, maximum, OneTo
 import Base.Broadcast: Broadcasted
 import ArrayLayouts: sub_materialize, axes_print_matrix_row
-import InfiniteArrays: OneToInf, PosInfinity, InfRanges, RealInfinity, Infinity, InfStepRange, TridiagonalToeplitzLayout
+import InfiniteArrays: OneToInf, PosInfinity, InfRanges, RealInfinity, Infinity, InfStepRange, TridiagonalToeplitzLayout, InfiniteCardinal
 import BlockArrays: AbstractBlockLayout, sizes_from_blocks, BlockTridiagonal, OneToCumsum, BlockSlice, AbstractBlockedUnitRange,
                     BlockLayout
 import LazyArrays: PaddedColumns, LazyArrayStyle
@@ -28,6 +28,8 @@ BlockArrays.blocklasts(a::InfRanges) = Fill(length(a),1)
 
 BlockArrays.findblock(::BlockedOneTo, ::RealInfinity) = Block(ℵ₀)
 
+maximum(::BlockRange{1, Tuple{OneTo{InfiniteCardinal{0}}}}) = Block(ℵ₀)
+
 function BlockArrays.sortedunion(a::Vcat{Int,1,<:Tuple{Union{Int,AbstractVector{Int}},<:AbstractRange}},
                                  b::Vcat{Int,1,<:Tuple{Union{Int,AbstractVector{Int}},<:AbstractRange}})
     @assert a == b # TODO: generailse? Not sure how to do so in a type stable fashion

diff --git a/test/test_infblock.jl b/test/test_infblock.jl
@@ -139,6 +139,11 @@ const BlockTriPertToeplitz = InfiniteArraysBlockArraysExt.BlockTriPertToeplitz
         @test findblock(blockedrange(1:2:∞), RealInfinity()) == Block(ℵ₀)
     end
 
+    @testset "maximum of Inf Block Range" begin
+        # See https://github.com/JuliaApproximation/HarmonicOrthogonalPolynomials.jl/pull/89
+        @test maximum(Block.(Base.OneTo(Integer(+∞)))) == Block(ℵ₀)
+    end
+
     @testset "BlockTridiagonal Pert Toeplitz" begin
         A = BlockTridiagonal(Vcat([fill(1.0, 2, 1), Matrix(1.0I, 2, 2), Matrix(1.0I, 2, 2), Matrix(1.0I, 2, 2)], Fill(Matrix(1.0I, 2, 2), ∞)),
                                 Vcat([zeros(1, 1)], Fill(zeros(2, 2), ∞)),