Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specalize istriu/istril #326

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 11, 2023

Avoid the fallbacks methods that loop over the entire array

julia> using LinearAlgebra, FillArrays

julia> @btime isdiag($(Ref(Zeros(1000,1000)))[]);
  4.408 μs (0 allocations: 0 bytes) # master
  1.687 ns (0 allocations: 0 bytes) # PR

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (373183f) 99.89% compared to head (899428a) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           8        8           
  Lines         919      923    +4     
=======================================
+ Hits          918      922    +4     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/fillalgebra.jl Outdated Show resolved Hide resolved
@jishnub jishnub changed the title Specalize isdiag and istriu/istril Specalize istriu/istril Dec 12, 2023
@dlfivefifty dlfivefifty merged commit c7c34aa into JuliaArrays:master Dec 12, 2023
24 checks passed
@jishnub jishnub deleted the isdiagbanded branch December 12, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants