Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use axes function instead of field access #320

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 5, 2023

When the axes for an abstract type are fetched, it's best to use axes(A) instead of A.axes to avoid assuming that there is a field with that name in every subtype.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c3d030) 95.25% compared to head (edd3556) 99.88%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   95.25%   99.88%   +4.63%     
==========================================
  Files           8        8              
  Lines         906      908       +2     
==========================================
+ Hits          863      907      +44     
+ Misses         43        1      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub added the bugfix label Dec 22, 2023
@jishnub jishnub requested a review from oxinabox February 25, 2024 09:01
@jishnub jishnub merged commit 2784902 into JuliaArrays:master Feb 27, 2024
24 checks passed
@jishnub jishnub deleted the axesinterface branch February 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants